Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for --skip-lock #5368

Merged
merged 12 commits into from
Sep 21, 2022
Merged

Fix for --skip-lock #5368

merged 12 commits into from
Sep 21, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Sep 21, 2022

Thank you for contributing to Pipenv!

The issue

Fixes #5367

Depends on: https://github.com/sarugaku/plette/pull/26/files

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 September 21, 2022 01:25
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plette has now version 0.3.1, and we can also add a test for this case.

I can confirm that this fix works.

@matteius matteius requested a review from oz123 September 21, 2022 11:00
@oz123 oz123 merged commit 074a91a into main Sep 21, 2022
@oz123 oz123 deleted the issue-5367b branch September 21, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv 2022.9.20 broken
2 participants