Removed usage of fs_str from vistir #5059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was all about compatability of py2-py3.3 versions. Later versions don't need it.
oz123
force-pushed
the
remove-vistir-fs_str
branch
4 times, most recently
from
a593b0b to
535359d
Compare
matteius
reviewed
Apr 19, 2022
|
OK, The latest commits don't have much to do with the title, but here is what they do:
To this:
There is an explicit step for linting, only if it passes the tests will run. If these pass, the vendoring will trigger, and once this is done we build a package with update vendoring code. |
matteius
reviewed
Apr 19, 2022
oz123
force-pushed
the
remove-vistir-fs_str
branch
from
4fb21d4 to
68cc0a7
Compare
This was referenced Apr 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I am suggesting to remove
fs_str.