Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version output #5838

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Fix the version output #5838

merged 2 commits into from
Aug 20, 2023

Conversation

matteius
Copy link
Member

Before:

matteius@matteius-VirtualBox:~/pipenv$ pipenv --version
pipenv
, version 2023.8.19

After:

matteius@matteius-VirtualBox:~/pipenv$ pipenv --version
pipenv, version 2023.8.19

The issue

We broke the benchmark run because unexpectedly the version output changed formats:.
https://github.com/lincolnloop/python-package-manager-shootout/actions/runs/5914571940/job/16040022277

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 August 20, 2023 07:55
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oz123 oz123 merged commit 795edf2 into main Aug 20, 2023
@oz123 oz123 deleted the fix-version-output branch August 20, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants