Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pipenv requirements" command doesn't export "extras" since version 2023.7.1 #5783

Closed
apolain opened this issue Jul 6, 2023 · 6 comments · Fixed by #5784
Closed

"pipenv requirements" command doesn't export "extras" since version 2023.7.1 #5783

apolain opened this issue Jul 6, 2023 · 6 comments · Fixed by #5784
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.

Comments

@apolain
Copy link

apolain commented Jul 6, 2023

Description

My problem could be linked to issue 5780.

In one of my projects, I use certain packages with "extras" (django-storages[azure])
Since version 2023.7.1, the pipenv requirements command ignores extras. As a result, the version specified in the Pipfile does not correspond to the version exported by pipenv requirements.

How to reproduct

My Pipfile looks like :

[packages]
[...]
django-storages = {version = "<1.13", extras = ["azure"]}
[...]

Before version 2023.7.1, pipenv requirements led me to:

$ pipenv --version 
2023.6.26

$ pipenv requirements
[...]
django-storages[azure]==1.12.3
[...]

And now I only have:

$ pipenv --version 
2023.7.4

$ pipenv requirements
[...]
django-storages==1.12.3
[...]
@matteius matteius added the Type: Duplicate This issue is a duplicate of an already-existing issue. label Jul 7, 2023
@matteius
Copy link
Member

matteius commented Jul 7, 2023

Same as issue #5780

@matteius
Copy link
Member

matteius commented Jul 7, 2023

Actually this is maybe a different issue.

@matteius matteius added Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. and removed Type: Duplicate This issue is a duplicate of an already-existing issue. labels Jul 7, 2023
@matteius
Copy link
Member

matteius commented Jul 7, 2023

I'm taking a shot a PR now for this issue.

@matteius
Copy link
Member

matteius commented Jul 7, 2023

I've tagged a PR that I think should fix this, if you could have a try and help determine if it still needs work (even added some test cases).

@matteius matteius added the Type: Regression This issue is a regression of a previous behavior. label Jul 7, 2023
@apolain
Copy link
Author

apolain commented Jul 7, 2023

Thank you very much, you've been so quick ! I try in the day and let you know :)

@apolain
Copy link
Author

apolain commented Jul 7, 2023

Hi @matteius, I confirm that the bug has been corrected with your changes. I see nothing more to add to this issue. Thank you again ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants