Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop cerberus, it seems it's not used anywhere #5699

Merged
merged 3 commits into from
May 21, 2023
Merged

Drop cerberus, it seems it's not used anywhere #5699

merged 3 commits into from
May 21, 2023

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented May 20, 2023

No description provided.

@oz123 oz123 requested a review from matteius May 20, 2023 11:56
@oz123 oz123 requested a review from matteius May 20, 2023 20:00
@oz123
Copy link
Contributor Author

oz123 commented May 20, 2023

I added 2 more commits, hence the requerst to review again.

@oz123 oz123 force-pushed the vendor-drop-cerberus branch from 3fb24a8 to 6c4a49a Compare May 21, 2023 07:01
@oz123 oz123 requested a review from matteius May 21, 2023 07:01
matteius
matteius approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@matteius matteius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure on one of the runners was network/github related.

@matteius matteius merged commit b1e3128 into main May 21, 2023
@matteius matteius deleted the vendor-drop-cerberus branch May 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteius matteius matteius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oz123 @matteius