-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update basics.rst with $SHELL
.
#2671
Conversation
State the role of `$SHELL` in `pipenv shell` command.
Update basics.rst with `$SHELL`.
Hi, the shell detection went through a couple of changes in recent versions. The current logic works like this:
So setting Thanks for the work! Documentation contribution is the best ❤️❤️❤️❤️ |
Ok, I'll try it, as my English is poor. My draft may need your correction. |
The 4th point, may be |
Ah yes, sorry, typo :) |
Add the description of `PIPENV_SHELL`
I just updated it, can you check it? |
Hi, this looks good! Only one thing—can you switch the link to use Sphinx’s reference syntax instead? |
Update link with Sphinx’s reference syntax.
En, I updated it again. |
docs/basics.rst
Outdated
@@ -326,6 +326,7 @@ You should do this for your shell too, in your ``~/.profile`` or ``~/.bashrc`` o | |||
|
|||
.. note:: The shell launched in interactive mode. This means that if your shell reads its configuration from a specific file for interactive mode (e.g. bash by default looks for a ``~/.bashrc`` configuration file for interactive mode), then you'll need to modify (or create) this file. | |||
|
|||
If you get something wrong with ``$ pipenv shell``, just check ``PIPENV_SHELL`` environment variable, ``$ pipenv shell`` will use it if available. For detail, see :ref:`configuration-with-environment-variables`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you get something wrong with
Can you change this to 'If you experience issues with`? Minor change but I think it's a tiny bit more natural.
just check
PIPENV_SHELL
environment variable
just check just check the PIPENV_SHELL
environment variable, $ pipenv shell
PIPENV_SHELL
environment variable, which $ pipenv shell
will use if available.
Minor tense changes mainly, thanks for contributing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Just updated. |
State the role of
$SHELL
inpipenv shell
command.