Nelfin fix 2229 #2262
Merged
Nelfin fix 2229 #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Urrgh Buildkite is failing and I can’t even see its logs. |
requirements.txt files (and by extension pipfreeze) can contain comment lines, but the stdout of pip freeze is used in a number of places with the assumption that every line contains a dependency declaration. This change adds an integration test that could trigger one of these cases that was the cause of the behaviour seen in issue #2229.
Ref #2229. This change only fixes the issue seen when calling `pipenv clean`. A future refactor should consolidate these behaviours (or use the actual parsing of lines from pip, i.e. FrozenRequirement, if we can rely on this API).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual merge. Close #2230.