Raise proper error if working under root

Author: frostming

pipenv/core.py

@@ -252,6 +252,12 @@ def ensure_pipfile(validate=True, skip_requirements=False, system=False):
     """Creates a Pipfile for the project, if it doesn't exist."""
     from .environments import PIPENV_VIRTUALENV
 
+    # Fail if working under /
+    if not project.name:
+        raise exceptions.PipenvUsageError(
+            "Pipenv is not intended to work under root directory, "
+            "please choose another path."
+        )
     # Assert Pipfile exists.
     python = which("python") if not (USING_DEFAULT_PYTHON or system) else None
     if project.pipfile_is_empty:
@@ -540,11 +546,12 @@ def ensure_project(
     # Automatically use an activated virtualenv.
     if PIPENV_USE_SYSTEM:
         system = True
-    if not project.pipfile_exists:
-        if deploy is True:
-            raise exceptions.PipfileNotFound
-        else:
-            project.touch_pipfile()
+    if not project.pipfile_exists and deploy:
+        raise exceptions.PipfileNotFound
+    # Ensure the Pipfile exists.
+    ensure_pipfile(
+        validate=validate, skip_requirements=skip_requirements, system=system
+    )
     # Skip virtualenv creation when --system was used.
     if not system:
         ensure_virtualenv(
@@ -584,10 +591,6 @@ def ensure_project(
                         )
                     else:
                         raise exceptions.DeployException
-    # Ensure the Pipfile exists.
-    ensure_pipfile(
-        validate=validate, skip_requirements=skip_requirements, system=system
-    )
 
 
 def shorten_path(location, bold=False):

pipenv/project.py

@@ -222,7 +222,7 @@ def name(self):
 
     @property
     def pipfile_exists(self):
-        return bool(self.pipfile_location)
+        return os.path.isfile(self.pipfile_location)
 
     @property
     def required_python_version(self):
@@ -470,7 +470,7 @@ def pipfile_location(self):
             try:
                 loc = pipfile.Pipfile.find(max_depth=PIPENV_MAX_DEPTH)
             except RuntimeError:
-                loc = None
+                loc = "Pipfile"
             self._pipfile_location = _normalized(loc)
         return self._pipfile_location
 
@@ -659,11 +659,6 @@ def dev_packages(self):
         """Returns a list of dev-packages, for pip-tools to consume."""
         return self._build_package_list("dev-packages")
 
-    def touch_pipfile(self):
-        """Simply touches the Pipfile, for later use."""
-        with open("Pipfile", "a"):
-            os.utime("Pipfile", None)
-
     @property
     def pipfile_is_empty(self):
         if not self.pipfile_exists:
@@ -680,7 +675,6 @@ def create_pipfile(self, python=None):
             ConfigOptionParser, make_option_group, index_group
         )
 
-        name = self.name if self.name is not None else "Pipfile"
         config_parser = ConfigOptionParser(name=self.name)
         config_parser.add_option_group(make_option_group(index_group, config_parser))
         install = config_parser.option_groups[0]