From 23dbe27544ed159b9ab3b5b988439dd08483ef3c Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Thu, 1 Feb 2024 04:35:38 -0500 Subject: [PATCH] Only editable entry should trigger editable installs (#6069) * Only editable entry should trigger editable installs * add news fragment --- news/6069.bugfix.rst | 1 + pipenv/utils/dependencies.py | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) create mode 100644 news/6069.bugfix.rst diff --git a/news/6069.bugfix.rst b/news/6069.bugfix.rst new file mode 100644 index 0000000000..2d3682e5f9 --- /dev/null +++ b/news/6069.bugfix.rst @@ -0,0 +1 @@ +Adjusted logic which assumed any file, path or VCS install should be considered editable. Instead relies on the user specified editable flag to mark requirement as editable install. diff --git a/pipenv/utils/dependencies.py b/pipenv/utils/dependencies.py index 10cae818b0..868ea5a4eb 100644 --- a/pipenv/utils/dependencies.py +++ b/pipenv/utils/dependencies.py @@ -1207,9 +1207,7 @@ def is_required_version(version, specified_version): def is_editable(pipfile_entry): if hasattr(pipfile_entry, "get"): - return pipfile_entry.get("editable", False) or any( - pipfile_entry.get(key) for key in ("file", "path") + VCS_LIST - ) + return pipfile_entry.get("editable", False) return False