Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_requires="string" not handled by PEP 517 backend #6255

Closed
blueyed opened this issue Feb 11, 2019 · 6 comments
Closed

setup_requires="string" not handled by PEP 517 backend #6255

blueyed opened this issue Feb 11, 2019 · 6 comments
Labels
auto-locked Outdated issues that have been locked by automation C: PEP 517 impact Affected by PEP 517 processing project: setuptools Related to setuptools

Comments

@blueyed
Copy link
Contributor

blueyed commented Feb 11, 2019

Related code:

with self.req.build_env:
# We need to have the env active when calling the hook.
self.req.spin_message = "Getting requirements to build wheel"
reqs = self.req.pep517_backend.get_requires_for_build_wheel()

reqs will be something like ['wheel', 's', 'e', 't', 'u', 'p', 'm', 'e', 't', 'a'] when using setup_requires='setupmeta'.

  • pip version: master (e5f4bbb)
  • Python version: 3.7.2
  • OS: Arch Linux

Ref: codrsquad/setupmeta#15 (comment)

@cjerdonek
Copy link
Member

Does this need to be fixed in setuptools rather since the PEP says the return value needs to be a list of strings? https://www.python.org/dev/peps/pep-0517/#get-requires-for-build-wheel

It looks like here is the setuptools code: https://github.com/pypa/setuptools/blob/cdb5eeae678d8ccc90bf7d4348013a294f11be75/setuptools/build_meta.py#L138

@gaborbernat
Copy link

Yeah, feels like a setuptools bug to me.

@cjerdonek cjerdonek added project: setuptools Related to setuptools C: PEP 517 impact Affected by PEP 517 processing S: needs triage Issues/PRs that need to be triaged labels Feb 12, 2019
@cjerdonek cjerdonek removed the S: needs triage Issues/PRs that need to be triaged label Mar 16, 2019
@cjerdonek
Copy link
Member

FYI, this has now been fixed in setuptools' master branch.

@chrahunt
Copy link
Member

Is there any action needed here?

@blueyed
Copy link
Contributor Author

blueyed commented Jul 24, 2019

Have not checked, closing as per previous from @cjerdonek comment.

@blueyed blueyed closed this as completed Jul 24, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: PEP 517 impact Affected by PEP 517 processing project: setuptools Related to setuptools
Projects
None yet
Development

No branches or pull requests

4 participants