Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include setuptools in upgrade set #454

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Include setuptools in upgrade set #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7bf4c4
_virtual_env: ensure setuptools is up-to-date
woodruffw Dec 28, 2022
b528849
_virtual_env: add TODO
woodruffw Dec 28, 2022
89fc832
CHANGELOG: record changes
woodruffw Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ All versions prior to 0.0.9 are untracked.

## [Unreleased]

### Fixed

* Fixed `pip-audit`'s virtual environment creation and upgrade behavior,
preventing spurious vulnerability reports
([#454](https://github.com/pypa/pip-audit/pull/454))

## [2.4.11]

### Fixed
Expand Down
3 changes: 3 additions & 0 deletions pip_audit/_virtual_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ def post_setup(self, context: SimpleNamespace) -> None:

# Firstly, upgrade our `pip` versions since `ensurepip` can leave us with an old version
# and install `wheel` in case our package dependencies are offered as wheels
# TODO: This is probably replaceable with the `upgrade_deps` option on `EnvBuilder`
# itself, starting with Python 3.9.
pip_upgrade_cmd = [
context.env_exe,
"-m",
Expand All @@ -86,6 +88,7 @@ def post_setup(self, context: SimpleNamespace) -> None:
"--upgrade",
"pip",
"wheel",
"setuptools",
]
try:
run(pip_upgrade_cmd, state=self._state)
Expand Down