Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclonedx-python-lib 6.0 and above breaks pip-audit #730

Closed
neilkk opened this issue Jan 31, 2024 · 3 comments
Closed

cyclonedx-python-lib 6.0 and above breaks pip-audit #730

neilkk opened this issue Jan 31, 2024 · 3 comments
Assignees
Labels
bug-candidate Might be a bug. needs-response Needs response from the reporter.

Comments

@neilkk
Copy link

neilkk commented Jan 31, 2024

$ python -c "from cyclonedx.parser import BaseParser"
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'cyclonedx.parser'

Removal PR below:
CycloneDX/cyclonedx-python-lib#489

@neilkk neilkk added the bug-candidate Might be a bug. label Jan 31, 2024
@woodruffw
Copy link
Member

woodruffw commented Jan 31, 2024

Thanks for the report @neilkk!

This strongly suggests an upstream semver breakage. I'll continue to diagnose. This now suggests either a user error or an outdated pip-audit version. We need more information to continue to triage.

(Could you please follow the bug report template for this issue and future ones? It makes our triaging efforts significantly easier. In particular, it would help to know which specific CycloneDX version you're using.)

@woodruffw woodruffw self-assigned this Jan 31, 2024
@woodruffw
Copy link
Member

From a quick look, our current imports don't contain BaseParser or cyclonedx.parser:

from cyclonedx import output
from cyclonedx.model.bom import Bom
from cyclonedx.model.component import Component
from cyclonedx.model.vulnerability import Vulnerability

We've supported 6.0+ since #715, which was merged in v2.7.0: https://github.com/pypa/pip-audit/releases/tag/v2.7.0

As such, this is almost certainly not a bug in current versions of pip-audit.

@woodruffw woodruffw added the needs-response Needs response from the reporter. label Jan 31, 2024
@neilkk
Copy link
Author

neilkk commented Jan 31, 2024

Sorry for the confusion, looks like we were running pip-audit v2.5.1

@neilkk neilkk closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-candidate Might be a bug. needs-response Needs response from the reporter.
Projects
None yet
Development

No branches or pull requests

2 participants