-
Notifications
You must be signed in to change notification settings - Fork 67
Adding logging when debug is enable #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the request. Could you clarify what about the current behavior isn't working for you? Does the current progress bar not freeze on failure and show you which audit was running when the command failed? (Either way, I'm not opposed to an extra debug log here -- just want to make sure I understand what the problem is!) |
In my case where I had to debug why I had the setuptools flagging even if I had set the correct package, I couldnt figure out which package was getting the information from. Adding this line, I was able to identify in few seconds which package was pulling the wrong version. You can see my logs on my previous ticket: #458 |
Makes sense, thank you! Would you mind making a short PR for that debug line? Otherwise, I'll add it sometime tonight or this weekend. |
It is handy if you can add some logging to this line which helps to understand what package is pulling the information without guessing what is wrong
https://github.com/pypa/pip-audit/blob/main/pip_audit/_cli.py#L465
I have used this solution to figure out what package was triggering the issue
logger.debug(f"Auditing {spec.name} ({spec.version})")
The text was updated successfully, but these errors were encountered: