Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include uv in tools? #1607

Closed
henryiii opened this issue May 9, 2024 · 9 comments · Fixed by #1614
Closed

Include uv in tools? #1607

henryiii opened this issue May 9, 2024 · 9 comments · Fixed by #1614

Comments

@henryiii
Copy link
Contributor

henryiii commented May 9, 2024

I'd like to try uv for cibuildwheel, and it's a single binary that works across Python versions, so it seems like adding it here would be a good first step. Thoughts?

Also, uv already supports free-threaded builds since astral-sh/uv#2805. :)

@mayeut
Copy link
Member

mayeut commented May 9, 2024

How do you plan to install it on Windows/macOS ?
I'd rather use pipx to install the binary (as it allows to track version changes easily without rewriting a specific update script) but this is not possible at the moment c.f. astral-sh/uv#3439

While the issue is related to gnu aarch64, the same is true for musllinux_1_1 compatibility (but on all arch)

@henryiii
Copy link
Contributor Author

henryiii commented May 9, 2024

I think this is fixed for the next release?

@mayeut
Copy link
Member

mayeut commented May 9, 2024

I think this is fixed for the next release?

for gnu aarrch64, it seems to be but not for musllinux_1_1, I'll create an issue tomorrow.

@henryiii
Copy link
Contributor Author

henryiii commented May 9, 2024

It looks like Rust doesn't support 32-bit musl with host tools (only without), and 64-bit musl is based on 1.2: https://doc.rust-lang.org/rustc/platform-support.html

@henryiii
Copy link
Contributor Author

I'm working on the first part here: astral-sh/uv#3523

It also needs the other archs. I notice muslllinux is completely missing from the readme, is that intentional?

@mayeut
Copy link
Member

mayeut commented May 11, 2024

is that intentional?

no, this is #1192

@henryiii
Copy link
Contributor Author

I'm not sure Rust has enough support for the special musl archs, see astral-sh/uv#3537. Would it be acceptable to add it for everything but those? I expect they are very lightly used.

@henryiii
Copy link
Contributor Author

uv muslllinux 1.1 wheels shipped. Only musllinux powerpc64le and s390x are missing now. Those are likely going to be tricky, though powerpcle64 might be the easier of the two.

@henryiii
Copy link
Contributor Author

musl ppc64le was doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants