Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to disable manylinux1 #522

Closed
xiispace opened this issue Jan 8, 2021 · 1 comment
Closed

how to disable manylinux1 #522

xiispace opened this issue Jan 8, 2021 · 1 comment

Comments

@xiispace
Copy link

xiispace commented Jan 8, 2021

after ci build, there are lots of whl files

hvloop-0.0.2-cp36-cp36m-manylinux1_x86_64.whl 
hvloop-0.0.2-cp36-cp36m-manylinux2010_x86_64.whl
hvloop-0.0.2-cp37-cp37m-manylinux1_x86_64.whl
hvloop-0.0.2-cp37-cp37m-manylinux2010_x86_64.whl

i only want the manylinux2010 files, is there some way to disabled the manylinux1 files build

below is my github action build.yml

name: Build and upload to PyPI

on: [push,]

jobs:
  build_wheels:
    name: Build whells on ${{ matrix.os }}
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [ubuntu-18.04, windows-2019, macos-10.15]

    steps:
      - uses: actions/checkout@v2
        with:
            submodules: true
      - uses: actions/setup-python@v2
        with:
            python-version: "3.8"
      - name: Install dependencies
        run: |
          pip install -U pip wheel
          pip install cibuildwheel

      - name: Build wheels
        run: |
          cibuildwheel --output-dir wheelhouse
        env:
          CIBW_BUILD: cp3?-*
          CIBW_SKIP: "*-win32 *-manylinux_i686 cp35-*"
          CIBW_BEFORE_BUILD: "pip install -U cython cmake"

      - name: Show files
        run: ls -lh wheelhouse
        shell: bash

      - uses: actions/upload-artifact@v2
        with:
          path: ./wheelhouse/*.whl
@joerick
Copy link
Contributor

joerick commented Jan 8, 2021

The manylinux1 files are produced as a side effect of the manylinux2010 build, auditwheel has a feature that if a manylinux2010 wheel is backward-compatible to manylinux1, it will produce two outputs. So you're not wasting any time building it, and some users might find it useful, there's probably no harm in keeping them and uploading them to PyPI.

Of course, if you still don't want them, rm wheelhouse/*-manylinux1_*.whl after calling cibuildwheel will remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants