Refactor and add zig dlltool support
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two private helper methods `write_def_file()` and `implib_file_name()`. Expand the docstrings on some public items.
Convert `build_dlltool_command()` megamethod into a new builder type using two-stage construction. Implement preliminary support for `zig dlltool` using the new `DllToolCommand` capabilities.
This was referenced May 14, 2022
Maturin sets `ZIG_COMMAND` environment variable when it is using `zig cc` to link the output binary.
The import library file extension is determined by the linker flavor, not the target environment per se. `zig cc` uses `lld` even when targeting `x86_64-windows-gnu`, so the import library should get the standard `.lib` extension. The `.dll.a` libraries are only understood by the MinGW (GNU) `ld`.
Test the new `zig dlltool` command functionality. Update unit tests to use the new builder API.
Add doctests for `ImportLibraryGenerator`.
It appears to use temporary object files which collide even when the output file paths are different.
ravenexp
changed the title
zig dlltool supportzig dlltool support
|
I think it's ready to merge now. |
messense
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the
dlltoolflavor selection and invocation code.