dns_server: fix race issue regarding rcode.

pymumu · pymumu · commit 04d68e7797d3 · 2024-03-04T22:24:09.000+08:00
diff --git a/src/dns_server.c b/src/dns_server.c
@@ -2622,6 +2622,10 @@ static int _dns_server_request_complete_with_all_IPs(struct dns_request *request
 				 request->ip_addr[9], request->ip_addr[10], request->ip_addr[11], request->ip_addr[12],
 				 request->ip_addr[13], request->ip_addr[14], request->ip_addr[15]);
 		}
+
+		if (request->rcode == DNS_RC_SERVFAIL && request->has_ip) {
+			request->rcode = DNS_RC_NOERROR;
+		}
 	}
 
 out:
@@ -7826,7 +7830,6 @@ static int _dns_server_tcp_process_one_request(struct dns_server_conn_tcp_client
 					goto errout;
 				}
 
-
 				if (http_decode_data == NULL) {
 					http_decode_data = malloc(DNS_IN_PACKSIZE);
 					if (http_decode_data == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -2622,6 +2622,10 @@ static int _dns_server_request_complete_with_all_IPs(struct dns_request *request`
`2622`	`2622`	`request->ip_addr[9], request->ip_addr[10], request->ip_addr[11], request->ip_addr[12],`
`2623`	`2623`	`request->ip_addr[13], request->ip_addr[14], request->ip_addr[15]);`
`2624`	`2624`	`}`
	`2625`	`+`
	`2626`	`+ if (request->rcode == DNS_RC_SERVFAIL && request->has_ip) {`
	`2627`	`+ request->rcode = DNS_RC_NOERROR;`
	`2628`	`+ }`
`2625`	`2629`	`}`
`2626`	`2630`
`2627`	`2631`	`out:`
`@@ -7826,7 +7830,6 @@ static int _dns_server_tcp_process_one_request(struct dns_server_conn_tcp_client`
`7826`	`7830`	`goto errout;`
`7827`	`7831`	`}`
`7828`	`7832`
`7829`		`-`
`7830`	`7833`	`if (http_decode_data == NULL) {`
`7831`	`7834`	`http_decode_data = malloc(DNS_IN_PACKSIZE);`
`7832`	`7835`	`if (http_decode_data == NULL) {`