You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we create a scaled RV (in relation to MiniBatching) we add an extra piece of information rvs_to_total_sizes (potentially renamed in #6331) in the Model that we use when obtaining the logp. It would be neat if we didn't have to do this, and could instead represent the RV itself as being a MiniBatchedRV or whatever (don't know if there is a mathematical concept for what we are trying to do here), which may take the total_size as an extra input.
This way we would obtain the right logp without the over-head of managing this extra mapping at the Model level. The fewer mappings we need to maintain the easier it is to transform Models, as in pymc-devs/pymc-extras#91
When we create a scaled RV (in relation to MiniBatching) we add an extra piece of information
rvs_to_total_sizes
(potentially renamed in #6331) in the Model that we use when obtaining the logp. It would be neat if we didn't have to do this, and could instead represent the RV itself as being a MiniBatchedRV or whatever (don't know if there is a mathematical concept for what we are trying to do here), which may take the total_size as an extra input.This way we would obtain the right logp without the over-head of managing this extra mapping at the Model level. The fewer mappings we need to maintain the easier it is to transform Models, as in pymc-devs/pymc-extras#91
Relevant code sections:
pymc/pymc/model.py
Lines 750 to 756 in b4c7eb1
pymc/pymc/distributions/logprob.py
Lines 302 to 305 in b4c7eb1
The text was updated successfully, but these errors were encountered: