-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 8 of BDA3 #65
Open
rosgori
wants to merge
11
commits into
pymc-devs:main
Choose a base branch
from
rosgori:chap_08
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capítulo 6 de BDA3
Capítulo 5 de BDA3
Hay varios problemas con respecto al modelo jerárquico
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
The hierarchical model in pymc3 was changed and improved, the results are similar
I think I finally understood the hierarchical model, and the results are quite similar. I have to change some visualizations and explain more about the model. |
The option `softmax` was added to both hierarchical models (PyStan and PyMC3). The results are identical between both (fortunately), but they are different from the book.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add this chapter to the main repository.
There is one example in this chapter:
I have used pymc3 to reproduce the results. I must say that there are some problems with the hierarchical model, the figure 8.1 (b) is almost the same, except for a minus sign. After months of redoing that example, I don't know a good solution to that. I also used pystan to reproduce the problems with the hierarchical model, although the idea is to remove that part before merging. If anyone has suggestions (either code or English), I'd like to hear them!