Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_histogram_approximation failing due to warning in newer JAX release #305

Closed
ricardoV94 opened this issue Feb 9, 2024 · 5 comments · Fixed by #307
Closed

test_histogram_approximation failing due to warning in newer JAX release #305

ricardoV94 opened this issue Feb 9, 2024 · 5 comments · Fixed by #307
Labels
tests

Comments

@ricardoV94
Copy link
Member

https://github.com/pymc-devs/pymc-experimental/actions/runs/7842985013/job/21402357791?pr=304#step:7:2388
This was referenced Feb 9, 2024
Merged
Merged
@jessegrabowski
Copy link
Member

Appears to be due to jax-ml/jax#18989

@jessegrabowski jessegrabowski mentioned this issue Feb 11, 2024
Closed
@ricardoV94
Copy link
Member Author

ricardoV94 commented Feb 11, 2024 •
edited
Loading

Is the histogram functionality using JAX @ferrine? I can't find any evidence for that, but the JAX warning comes from the histogram tests

@jessegrabowski
Copy link
Member

jessegrabowski commented Feb 11, 2024 •
edited
Loading

I think it's related to pm.sample, not histogram. There are test in test_linear_model and test_model_builder that are also failing because they call pm.sample.

We maybe have to split up the CI so that JAX dependencies are run separately and in JAX mode, like PyMC does

@jessegrabowski jessegrabowski mentioned this issue Feb 11, 2024
Merged
@ricardoV94
Copy link
Member Author

ricardoV94 commented Feb 11, 2024 •
edited
Loading

So if JAX is loaded it will issue a warning on os.fork even if it's not being used?

@ricardoV94
Copy link
Member Author

Then let's just ignore the warning, it's stupid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JAX warnings in tests jessegrabowski/pymc-experimental
2 participants
@ricardoV94 @jessegrabowski