Skip to content

Select last inferred value for usage #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Select last inferred value for usage #4357

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54ec6fd
Select last inferred value for usage
Alphadelta14 Apr 14, 2021
186cae4
Do not explicitly require https://github.com/PyCQA/astroid/pull/1097
Alphadelta14 Jul 12, 2021
6128fb7
Update pylint/checkers/utils.py
Pierre-Sassoulas Apr 3, 2022
4dfb89d
Update pylint/checkers/utils.py
Pierre-Sassoulas Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pylint/checkers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,6 +1227,17 @@ def safe_infer(
and len(inferred.args.args) != len(value.args.args)
):
return None # Different number of arguments indicates ambiguity
if isinstance(inferred, astroid.objects.PartialFunction):
# Before https://github.com/PyCQA/astroid/pull/1097,
# partials got placed into the same scope as parents
# even though they usually have different names and may be
# defined elsewhere.
# We do not select the later value in this case.
# This condition can be removed if astroid#1097 is
# guaranteed to be present.
continue
# For multiple inferences of the same type, select the last one
value = inferred
except astroid.InferenceError:
return None # There is some kind of ambiguity
except StopIteration:
Expand Down