From 75412b318c3e88de87ac7c02a6218359f431d08a Mon Sep 17 00:00:00 2001 From: harupy Date: Sat, 23 Nov 2024 12:52:58 +0900 Subject: [PATCH 1/2] Support os.environ.get Signed-off-by: harupy --- doc/data/messages/i/invalid-envvar-default/bad.py | 1 + doc/data/messages/i/invalid-envvar-default/good.py | 1 + pylint/checkers/stdlib.py | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/data/messages/i/invalid-envvar-default/bad.py b/doc/data/messages/i/invalid-envvar-default/bad.py index 9b564b9c8c..f87b0de304 100644 --- a/doc/data/messages/i/invalid-envvar-default/bad.py +++ b/doc/data/messages/i/invalid-envvar-default/bad.py @@ -1,3 +1,4 @@ import os env = os.getenv("SECRET_KEY", 1) # [invalid-envvar-default] +env = os.environ.get("SECRET_KEY", 1) # [invalid-envvar-default] diff --git a/doc/data/messages/i/invalid-envvar-default/good.py b/doc/data/messages/i/invalid-envvar-default/good.py index 103925941e..bcc41cb13c 100644 --- a/doc/data/messages/i/invalid-envvar-default/good.py +++ b/doc/data/messages/i/invalid-envvar-default/good.py @@ -1,3 +1,4 @@ import os env = os.getenv("SECRET_KEY", "1") +env = os.environ.get("SECRET_KEY", "1") diff --git a/pylint/checkers/stdlib.py b/pylint/checkers/stdlib.py index 9225cd4d26..b9591a61ae 100644 --- a/pylint/checkers/stdlib.py +++ b/pylint/checkers/stdlib.py @@ -30,7 +30,7 @@ THREADING_THREAD = "threading.Thread" COPY_COPY = "copy.copy" OS_ENVIRON = "os._Environ" -ENV_GETTERS = ("os.getenv",) +ENV_GETTERS = ("os.getenv", "os.environ.get") SUBPROCESS_POPEN = "subprocess.Popen" SUBPROCESS_RUN = "subprocess.run" OPEN_MODULE = {"_io", "pathlib", "pathlib._local"} From 4388b82bb96c2a9978d11745aa1e088700cb7cee Mon Sep 17 00:00:00 2001 From: harupy Date: Sat, 23 Nov 2024 12:58:34 +0900 Subject: [PATCH 2/2] Add frafment Signed-off-by: harupy --- doc/whatsnew/fragments/10092.false_negative | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 doc/whatsnew/fragments/10092.false_negative diff --git a/doc/whatsnew/fragments/10092.false_negative b/doc/whatsnew/fragments/10092.false_negative new file mode 100644 index 0000000000..764aa756ea --- /dev/null +++ b/doc/whatsnew/fragments/10092.false_negative @@ -0,0 +1,3 @@ +Fix false negative for `invalid-envvar-default` to detect `os.environ.get`. + +Closes #10092