From e507a4d87ec80e706ac0c8ce2d23bd28006cbbbc Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 24 Apr 2023 19:50:25 +0000 Subject: [PATCH] Fix a false positive for ``bad-dunder-name`` when there is a user-defined ``__index__`` method. (#8619) (#8622) Closes #8613 (cherry picked from commit f223c6de3a39eae6d1c76e30b55da28639dd8777) Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com> --- doc/whatsnew/fragments/8613.false_positive | 3 +++ pylint/constants.py | 1 + tests/functional/ext/bad_dunder/bad_dunder_name.py | 3 +++ 3 files changed, 7 insertions(+) create mode 100644 doc/whatsnew/fragments/8613.false_positive diff --git a/doc/whatsnew/fragments/8613.false_positive b/doc/whatsnew/fragments/8613.false_positive new file mode 100644 index 0000000000..80d28e9c23 --- /dev/null +++ b/doc/whatsnew/fragments/8613.false_positive @@ -0,0 +1,3 @@ +Fix a false positive for ``bad-dunder-name`` when there is a user-defined ``__index__`` method. + +Closes #8613 diff --git a/pylint/constants.py b/pylint/constants.py index ad7fc2256f..de29fb9b87 100644 --- a/pylint/constants.py +++ b/pylint/constants.py @@ -281,6 +281,7 @@ def _get_pylint_home() -> str: "__getnewargs_ex__", "__getnewargs__", "__getstate__", + "__index__", "__setstate__", "__reduce__", "__reduce_ex__", diff --git a/tests/functional/ext/bad_dunder/bad_dunder_name.py b/tests/functional/ext/bad_dunder/bad_dunder_name.py index 48247aba03..6008866b1d 100644 --- a/tests/functional/ext/bad_dunder/bad_dunder_name.py +++ b/tests/functional/ext/bad_dunder/bad_dunder_name.py @@ -49,6 +49,9 @@ def __private_method(self): def __doc__(self): return "Docstring" + def __index__(self): + return 1 + def __increase_me__(val): return val + 1