Code review

Author: cdce8p

pylint/checkers/typecheck.py

@@ -1817,10 +1817,9 @@ def _check_invalid_slice_index(self, node: nodes.Slice) -> None:
             match index_type := safe_infer(index):
                 case _ if not index_type:
                     continue
-                case nodes.Const():
+                case nodes.Const(value=int() | None):
                     # Constants must be of type int or None
-                    if isinstance(index_type.value, (int, type(None))):
-                        continue
+                    continue
                 case astroid.Instance():
                     # Instance values must be of type int, None or an object
                     # with __index__

pylint/checkers/variables.py

@@ -650,29 +650,30 @@ def get_next_to_consume(self, node: nodes.Name) -> list[nodes.NodeNG] | None:
     def _inferred_to_define_name_raise_or_return(
         self,
         name: str,
-        node: nodes.NodeNG,
+        node: nodes.Try | nodes.With | nodes.For | nodes.While | nodes.Match | nodes.If,
     ) -> bool:
         """Return True if there is a path under this `if_node`
         that is inferred to define `name`, raise, or return.
         """
-        # Handle try and with
-        if isinstance(node, nodes.Try):
-            # Allow either a path through try/else/finally OR a path through ALL except handlers
-            try_except_node = node
-            if node.finalbody:
-                try_except_node = next(
-                    (child for child in node.nodes_of_class(nodes.Try)),
-                    None,
+        match node:
+            case nodes.Try():
+                # Allow either a path through try/else/finally OR a path through ALL except handlers
+                try_except_node = node
+                if node.finalbody:
+                    try_except_node = next(
+                        (child for child in node.nodes_of_class(nodes.Try)),
+                        None,
+                    )
+                handlers = try_except_node.handlers if try_except_node else []
+                return NamesConsumer._defines_name_raises_or_returns_recursive(
+                    name, node
+                ) or all(
+                    NamesConsumer._defines_name_raises_or_returns_recursive(
+                        name, handler
+                    )
+                    for handler in handlers
                 )
-            handlers = try_except_node.handlers if try_except_node else []
-            return NamesConsumer._defines_name_raises_or_returns_recursive(
-                name, node
-            ) or all(
-                NamesConsumer._defines_name_raises_or_returns_recursive(name, handler)
-                for handler in handlers
-            )
 
-        match node:
             case nodes.With() | nodes.For() | nodes.While():
                 return NamesConsumer._defines_name_raises_or_returns_recursive(
                     name, node
@@ -684,12 +685,17 @@ def _inferred_to_define_name_raise_or_return(
                     for case in node.cases
                 )
             case nodes.If():
-                pass
+                return self._inferred_to_define_name_raise_or_return_for_if_node(
+                    name, node
+                )
             case _:  # pragma: no cover
                 # The function is only called for Try, With, For, While, Match and
                 # If nodes. All of which are being handled above.
                 raise AssertionError
 
+    def _inferred_to_define_name_raise_or_return_for_if_node(
+        self, name: str, node: nodes.If
+    ) -> bool:
         # Be permissive if there is a break or a continue
         if any(node.nodes_of_class(nodes.Break, nodes.Continue)):
             return True