Add tests to improve coverage (#8096)

Author: clavedeluna

pylint/checkers/base_checker.py

@@ -235,6 +235,12 @@ def messages(self) -> list[MessageDefinition]:
         ]
 
     def get_message_definition(self, msgid: str) -> MessageDefinition:
+        # TODO: 3.0: Remove deprecated method
+        warnings.warn(
+            "'get_message_definition' is deprecated and will be removed in 3.0.",
+            DeprecationWarning,
+            stacklevel=2,
+        )
         for message_definition in self.messages:
             if message_definition.msgid == msgid:
                 return message_definition

pylint/checkers/classes/special_methods_checker.py

@@ -296,9 +296,6 @@ def _is_dict(node: InferenceResult) -> bool:
 
     @staticmethod
     def _is_iterator(node: InferenceResult) -> bool:
-        if node is astroid.Uninferable:
-            # Just ignore Uninferable objects.
-            return True
         if isinstance(node, bases.Generator):
             # Generators can be iterated.
             return True

pylint/checkers/typecheck.py

@@ -499,16 +499,7 @@ def _emit_no_member(
                 return False
         except astroid.NotFoundError:
             return True
-    if (
-        owner.parent
-        and isinstance(owner.parent, nodes.ClassDef)
-        and owner.parent.name == "EnumMeta"
-        and owner_name == "__members__"
-        and node.attrname in {"items", "values", "keys"}
-    ):
-        # Avoid false positive on Enum.__members__.{items(), values, keys}
-        # See https://github.com/PyCQA/pylint/issues/4123
-        return False
+
     # Don't emit no-member if guarded behind `IF` or `IFExp`
     #   * Walk up recursively until if statement is found.
     #   * Check if condition can be inferred as `Const`,

tests/checkers/unittest_base_checker.py

@@ -4,10 +4,12 @@
 
 """Unittest for the BaseChecker class."""
 
+import pytest
 
 from pylint.checkers import BaseChecker
 from pylint.checkers.imports import ImportsChecker
 from pylint.checkers.typecheck import TypeChecker
+from pylint.exceptions import InvalidMessageError
 from pylint.extensions.while_used import WhileChecker
 from pylint.lint.pylinter import PyLinter
 
@@ -26,6 +28,11 @@ def __init__(self) -> None:
     }
 
 
+class MissingFieldsChecker(BaseChecker):
+    name = "basic"
+    msgs = {"W0001": ("msg-name",)}  # type: ignore[dict-item]
+
+
 class LessBasicChecker(OtherBasicChecker):
     options = (
         (
@@ -121,3 +128,20 @@ def test_base_checker_ordering() -> None:
     assert fake_checker_1 > fake_checker_3
     assert fake_checker_2 > fake_checker_3
     assert fake_checker_1 == fake_checker_2
+
+
+def test_base_checker_invalid_message() -> None:
+    linter = PyLinter()
+
+    with pytest.raises(InvalidMessageError):
+        linter.register_checker(MissingFieldsChecker(linter))
+
+
+def test_get_message_definition() -> None:
+    checker = LessBasicChecker()
+    with pytest.warns(DeprecationWarning):
+        with pytest.raises(InvalidMessageError):
+            checker.get_message_definition("W123")
+
+    with pytest.warns(DeprecationWarning):
+        assert checker.get_message_definition("W0001")

tests/functional/n/non/non_iterator_returned.py

@@ -1,7 +1,7 @@
 """Check non-iterators returned by __iter__ """
 
-# pylint: disable=too-few-public-methods, missing-docstring, consider-using-with
-
+# pylint: disable=too-few-public-methods, missing-docstring, consider-using-with, import-error
+from uninferable import UNINFERABLE
 
 class FirstGoodIterator:
     """ yields in iterator. """
@@ -99,3 +99,9 @@ class FourthBadIterator:
 
     def __iter__(self):  # [non-iterator-returned]
         return ThirdBadIterator
+
+class SixthGoodIterator:
+    """__iter__ returns Uninferable."""
+
+    def __iter__(self):
+        return UNINFERABLE