-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove metaclass check for protected access in properties (#9966)
1. it was incorrect when the property wasn't inside a class and the enclosing class didn't have an explicit metaclass 2. The conjugated test is full with errors and I can't understand the intention. (the errors: `MC` doesn't inherit `type`; `_nargs` isn't defined; `obj` isn't defined, etc). What is the pointed of testing protected access on an undefined variable?.. (See full discussions on the MR for reasoning)
- Loading branch information
1 parent
0d7b0d7
commit 5feface
Showing
3 changed files
with
4 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
protected-access:19:0:19:9::Access to a protected member _teta of a client class:UNDEFINED | ||
protected-access:31:16:31:26:Application.__no_special__:Access to a protected member _nargs of a client class:UNDEFINED | ||
protected-access:41:14:41:35:Light.func:Access to a protected member _light_internal of a client class:UNDEFINED | ||
protected-access:45:10:45:31:func:Access to a protected member _light_internal of a client class:UNDEFINED | ||
protected-access:29:14:29:35:Light.func:Access to a protected member _light_internal of a client class:UNDEFINED | ||
protected-access:33:10:33:31:func:Access to a protected member _light_internal of a client class:UNDEFINED |