Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate set_mode depth argument #2490

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Deprecate set_mode depth argument #2490

merged 1 commit into from
Oct 3, 2023

Conversation

zoldalma999
Copy link
Member

@zoldalma999 zoldalma999 commented Oct 2, 2023 •
edited
Loading

Fixes #635, fixes #2329

I don't think we want to support setting the depth of the window surface

@zoldalma999 zoldalma999 requested a review from a team as a code owner October 2, 2023 10:44
ankith26
ankith26 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed the way forward, thanks for the PR 🎈

@ankith26 ankith26 added Deprecation Warning Surface pygame.Surface display pygame.display and removed Surface pygame.Surface labels Oct 2, 2023
@ankith26 ankith26 added this to the 2.4.0 milestone Oct 2, 2023
MyreMylar
MyreMylar approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankith26 ankith26 merged commit deb27b0 into pygame-community:main Oct 3, 2023
31 checks passed
@zoldalma999 zoldalma999 deleted the set_mode-depth branch March 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
Deprecation Warning display pygame.display
Projects
None yet
Milestone
2.4.0
3 participants
@zoldalma999 @MyreMylar @ankith26