Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter failing due to new clang-format version #2461

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix linter failing due to new clang-format version #2461

merged 1 commit into from
Sep 21, 2023

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Sep 20, 2023

So clang-format got updated and now the linter is failing because it wants to format some stuff, well, this PR formats that stuff.

@Matiiss Matiiss requested a review from a team as a code owner September 20, 2023 08:30
@yunline yunline mentioned this pull request Sep 21, 2023
Closed
yunline
yunline approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starbuck5
Starbuck5 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Starbuck5 Starbuck5 merged commit b64eb76 into pygame-community:main Sep 21, 2023
31 checks passed
@Starbuck5 Starbuck5 added this to the 2.4.0 milestone Sep 21, 2023
@Matiiss Matiiss deleted the matiiss-run-new-clang-format branch September 21, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@yunline yunline yunline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Matiiss @yunline @Starbuck5