Remove conan buildconfig #2460
Merged
Remove conan buildconfig #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
buildconfig
Code quality/robustness
I'm not sure this was ever used, but it was developed several years ago and hasn't been used since.
Starbuck5
force-pushed
the
remove-conan
branch
from
3169ab0
to
55ea7f5
Compare
ankith26
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
I remember having an older PR with deps updates that did these cleanups, but I like that you opened a dedicated PR as it can get merged more easily.
PS: You are deleting a file in the travis folder, IMO the whole folder can be deleted. The appveyor folder too. We don't really use it, and even if we need to at some point, then we always have git history ;)
Anyways you have my approval. You can take the call on doing the other cleanups in this PR
|
I'll stick with just conan for now, keep it small. :) |
pmp-p
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this was ever used, but it was developed several years ago and hasn't been used since.