Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use format instead of masks (4) #2439

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Use format instead of masks (4) #2439

merged 1 commit into from
Sep 9, 2023

Conversation

Starbuck5
Copy link
Member

Easier to port to SDL3.

Continuing from #2328

@Starbuck5
Use format instead of masks
eb5343b 
Easier to port to SDL3
@Starbuck5 Starbuck5 added the sdl3 label Sep 8, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner September 8, 2023 04:26
@Starbuck5 Starbuck5 changed the title Use format instead of masks Use format instead of masks (4) Sep 8, 2023
@Starbuck5 Starbuck5 mentioned this pull request Sep 8, 2023
Merged
dr0id
dr0id approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the depth is set to 0 because it is defined by the pixelformat.

Thanks for the PR.

ankith26
ankith26 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@Starbuck5 Starbuck5 merged commit d2bef66 into pygame-community:main Sep 9, 2023
31 checks passed
@Starbuck5 Starbuck5 deleted the use-format-not-masks branch September 9, 2023 04:26
@ankith26 ankith26 added this to the 2.4.0 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@dr0id dr0id dr0id approved these changes

Assignees
No one assigned
Labels
sdl3
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @dr0id @ankith26