Remove sdlmain_osx.m #2357
Merged
Remove sdlmain_osx.m #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
Code quality/robustness
ankith26
requested changes
Aug 1, 2023
It used to be a functional component, but right now it's just vestigial, and caused a build failure for one of our contributors.
Starbuck5
force-pushed
the
remove-sdlmain
branch
from
dd43617
to
e7c4743
Compare
Rebasing against main removes the first commit. And done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be a functional component, but right now it's just vestigial, and caused a build failure for one of our contributors.
Closes #2142
Branched from #2356, which should be merged first.