Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding random 1-bit images fails #85

Open
scaramallion opened this issue Mar 17, 2024 · 1 comment
Open

Encoding random 1-bit images fails #85

scaramallion opened this issue Mar 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@scaramallion
Copy link
Member

scaramallion commented Mar 17, 2024

There's an upstream issue with openjpeg not encoding 1-bit images correctly if they're over a certain size. Which I missed in testing because I set the upper limit on the random arrays incorrectly (range is [0, high), not [0, high]...)

Workaround is to use a precision of 2 instead.

@scaramallion scaramallion added the bug Something isn't working label Mar 17, 2024
@scaramallion
Copy link
Member Author

scaramallion commented Mar 20, 2024

After a bit more exploring I think that this should be OK for most normal 1-bit images, it's using purely random images that's one of the causes of the issue.

@scaramallion scaramallion changed the title Encoding 1-bit images fails Encoding random 1-bit images fails Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant