Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define max version for pydicom to avoid breaking changes #267

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

sammaxwellxyz
Copy link
Contributor

Description

Related issues: #266 #266

define install requires to include upper bound for pydicom.

the preference may be for an update to adopt pydicom 3 but this may be a useful fix in the short term as that may introduce breaking changes

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code follows the style guidelines of this project (i think)

Open questions

Questions that require more discussion or to be addressed in future development:

you may want a similar upper bound for numpy, accidentally adopting 2+ has been an issue for some

@vsoch
Copy link
Member

vsoch commented Oct 1, 2024

Good thinking to get this in for a closer version (before we bump up). Could you please bump the version in deid/version.py and put a note in the changelog?

@vsoch
Copy link
Member

vsoch commented Oct 2, 2024

@sammaxwellxyz looks like there is just a linting issue - we have it pinned to black 23.3.0, so either running that version or updating the pin (and running the version you choose on the codebase) would work here. Thanks!

@vsoch vsoch merged commit 830966d into pydicom:master Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants