Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Datasets made from BytesIO #265

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Handle Datasets made from BytesIO #265

merged 4 commits into from
Sep 5, 2024

Conversation

barrettMCW
Copy link
Contributor

Ran into an issue using DicomParser on pydicom.Dataset objects created from BytesIO, this should fix it.

@barrettMCW
Copy link
Contributor Author

oops, i did the change in github so didn't get a squiggle about import order. isort should be happy now

@wetzelj
Copy link
Contributor

wetzelj commented Sep 5, 2024

@vsoch - I took a peek at this. Looks fine to me.

@barrettMCW - Pending approval from @vsoch, please ensure that you bump the version and add an entry to the changelog.

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vsoch vsoch merged commit ebae1c6 into pydicom:master Sep 5, 2024
3 checks passed
@barrettMCW barrettMCW deleted the patch-1 branch September 5, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants