Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Multivalued Fields to %values Lists #174

Closed
wetzelj opened this issue Jun 28, 2021 · 3 comments
Closed

Adding Multivalued Fields to %values Lists #174

wetzelj opened this issue Jun 28, 2021 · 3 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Jun 28, 2021

When fields specified within recipe file %values lists contain a list of items, the addition of the Multi-value value to the values array causes an exception (Exception: unhashable type: 'MultiValue').

I believe that this can be corrected checking the type of the value first - if it is MultiValue, we can use set.Update() to update the values list instead of using set.Add().

I've committed a possible fix to the wetzelj/deid INFOR-831 branch.

@vsoch
Copy link
Member

vsoch commented Jun 28, 2021

@wetzelj let's take these one by one! If there are easy fixes (like the one) let's do a PR from your branch and bumping the version. More complex issues (or ones you want my help with) I could take a look in an evening or weekend.

@wetzelj
Copy link
Contributor Author

wetzelj commented Jun 29, 2021

@vsoch Sounds good... it's on its way

@vsoch
Copy link
Member

vsoch commented Jun 30, 2021

This is all set.

@vsoch vsoch closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants