Skip to content

Raise errors on new warnings from within xarray #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-sixty merged 9 commits into from
Apr 29, 2024
Merged

Raise errors on new warnings from within xarray #8974

max-sixty merged 9 commits into from
Apr 29, 2024

Conversation

@max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Apr 25, 2024

Notes are inline.

Done with some help from an LLM — quite good for doing tedious tasks that we otherwise wouldn't want to do — can paste in all the warnings output and get a decent start on rules for exclusions

@max-sixty
Copy link
Collaborator Author

max-sixty commented Apr 28, 2024

Going to merge this as it's time-sensitive.

PRs that don't merge main back in may cause broken tests; I will endeavor to fix asap. And there are comments inline for how to deal with errors — post here or tag me on PRs if something comes up.

@max-sixty max-sixty enabled auto-merge (squash) April 28, 2024 23:24
@max-sixty max-sixty disabled auto-merge April 28, 2024 23:25
@max-sixty max-sixty enabled auto-merge (squash) April 28, 2024 23:35
@max-sixty max-sixty merged commit 36a9cbc into pydata:main Apr 29, 2024
@max-sixty max-sixty deleted the warnings branch April 29, 2024 02:50
@keewis
Copy link
Collaborator

keewis commented Apr 29, 2024

Was this supposed to close #8494? If so, that didn't work so you might have to close it manually.

@max-sixty max-sixty mentioned this pull request Apr 29, 2024
Closed
max-sixty added a commit to max-sixty/xarray that referenced this pull request May 10, 2024
@max-sixty
Add whatsnew entry for pydata#8974
4d8cedf 
Responding to call-out at pydata#9021 !
dcherian pushed a commit that referenced this pull request May 11, 2024
@max-sixty
Add whatsnew entry for #8974 (#9022)
b9c124b 
Responding to call-out at #9021 !
andersy005 added a commit that referenced this pull request May 12, 2024
@andersy005
Merge branch 'main' into backend-indexing
7d55345 
* main:
  Add whatsnew entry for #8974 (#9022)
  Zarr: Optimize appending (#8998)
@spencerkclark spencerkclark mentioned this pull request Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty @keewis