Readd order and subok parameters to astype (GH4644) #4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper quotes in docstrings Co-authored-by: Mathias Hauser <[email protected]>
Collaborator
|
One more point, could you add "sparse": ("https://sparse.pydata.org/en/latest/", None), here: Line 420 in bdba889 so we get the cross-link to sparse (in the docs). Then I'll merge in a few days unless someone else has comments. |
1 task
dcherian
reviewed
Dec 14, 2020
| Notes | ||
| ----- | ||
| The ``order``, ``casting``, ``subok`` and ``copy`` arguments are only passed |
Contributor
There was a problem hiding this comment.
@pydata/xarray are we ok with this as a general policy for functions that are light wrappers of the underlying array-type's method.
Collaborator
There was a problem hiding this comment.
Hmm true we don't really do this in other places AFAIK. However, it is similar to passing **kwargs on.
Member
There was a problem hiding this comment.
This looks like a good solution to me!
Collaborator
|
Merging... Thanks @rhkleijn & welcome to xarray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rst