Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indexing performance benchmarks #3382

Open
crusaderky opened this issue Oct 8, 2019 · 0 comments
Open

Improve indexing performance benchmarks #3382

crusaderky opened this issue Oct 8, 2019 · 0 comments

Comments

@crusaderky
Copy link
Contributor

crusaderky commented Oct 8, 2019

As discussed in #3375 - FYI @jhamman

asv_bench/benchmarks/indexing.py is currently missing some key use cases:

  • All tests in the above module use arrays with 2~6 million points.
    While this is important to spot any case where the numpy underlying functions start being unnecessarily called more than once, it also means any performance improvement or degradation in any of the pure-Python code will be completely drowned out.
    All tests should be run twice, once with the current nx = 3000; ny = 2000; nt = 1000 and again with nx = 15; ny = 10; nt = 5.
  • DataArray slicing (sel, isel, and square brackets)
  • Slicing when there are no IndexVariables (verify that we're not creating dummy variables, doing a full scan on them, and then discarding them)
  • other?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant