test and docstring updates

Author: dnowacki-usgs

xarray/core/common.py

@@ -1332,6 +1332,11 @@ def astype(self, dtype, casting="unsafe", copy=True, keep_attrs=True):
             By default, astype keeps attributes. Set to False to remove
             attributes in the returned object.
 
+        Returns
+        -------
+        out : same as object
+            New object with data cast to the specified type.
+
         See also
         --------
         np.ndarray.astype

xarray/core/variable.py

@@ -386,6 +386,11 @@ def astype(self, dtype, casting="unsafe", copy=True, keep_attrs=True):
             By default, astype keeps attributes. Set to False to remove
             attributes in the returned object.
 
+        Returns
+        -------
+        out : same as object
+            New object with data cast to the specified type.
+
         See also
         --------
         np.ndarray.astype

xarray/tests/test_dataarray.py

@@ -1877,8 +1877,8 @@ def test_array_interface(self):
     def test_astype_attrs(self):
         for v in [self.va.copy(), self.mda.copy(), self.ds.copy()]:
             v.attrs["foo"] = "bar"
-            assert list(v.attrs.items()) == list(v.astype(float).attrs.items())
-            assert [] == list(v.astype(float, keep_attrs=False).attrs.items())
+            assert v.attrs == v.astype(float).attrs
+            assert not v.astype(float, keep_attrs=False).attrs
 
     def test_astype_dtype(self):
         original = DataArray([-1, 1, 2, 3, 1000])

xarray/tests/test_dataset.py

@@ -5611,12 +5611,10 @@ def test_astype_attrs(self):
         data = create_test_data(seed=123)
         data.attrs["foo"] = "bar"
 
-        assert list(data.attrs.items()) == list(data.astype(float).attrs.items())
-        assert list(data.var1.attrs.items()) == list(
-            data.astype(float).var1.attrs.items()
-        )
-        assert [] == list(data.astype(float, keep_attrs=False).attrs.items())
-        assert [] == list(data.astype(float, keep_attrs=False).var1.attrs.items())
+        assert data.attrs == data.astype(float).attrs
+        assert data.var1.attrs == data.astype(float).var1.attrs
+        assert not data.astype(float, keep_attrs=False).attrs
+        assert not data.astype(float, keep_attrs=False).var1.attrs
 
 
 # Py.test tests