Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build sdist on CI and include self_schema.py #174

Closed
samuelcolvin opened this issue Jul 18, 2022 · 2 comments · Fixed by #175
Closed

build sdist on CI and include self_schema.py #174

samuelcolvin opened this issue Jul 18, 2022 · 2 comments · Fixed by #175

Comments

@samuelcolvin
Copy link
Member

as per #173 (comment)

We need to build sdist on CI and include self_schema.py.
@samuelcolvin
Copy link
Member Author

@messense should we also add src/self_schema.py to MANIFEST.in?

@messense
Copy link
Contributor

MANIFEST.in is useless when not using setuptools or setuptools-rust(PyO3/maturin#554 (comment)).

tool.maturin.sdist-include in pyproject.toml can be used if needed, see https://maturin.rs/distribution.html#source-distribution

@messense messense mentioned this issue Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build source distribution messense/pydantic-core
2 participants
@messense @samuelcolvin