Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: bumb-pydantic doesnt change files #135

Closed
jjfantini opened this issue Oct 21, 2023 · 2 comments · Fixed by #143
Closed

[BUG]: bumb-pydantic doesnt change files #135

jjfantini opened this issue Oct 21, 2023 · 2 comments · Fixed by #143

Comments

@jjfantini
Copy link

OS: Wndows 11
IDE: Cursor

I am in a fresh fork of patito in local dev, using a conda env.

THHs depends on pydantic v1 and I am looking to change to support v2, thus using bump-pydantic

(venv_patito)PS C:\Users\<user>\<wd>\patito> bump-pydantic src/patito
[10:38:16] Start bump-pydantic.                                                                                         main.py:61
           Found 10 files to process                                                                                    main.py:76
[10:38:32] Run successfully!                                                                                           main.py:149
(venv_patito)PS C:\Users\<user>\<wd>\patito> 

However, git doesn't track any changes and only generates an empty log.txt file. I've also been in src directory with the same outcome.

Shouldn't I get an error somewhere?

@jjfantini
Copy link
Author

patito_pydantic_upgrade.mp4
patito_pydantic_upgrade2.mp4

@Kludex
Copy link
Member

Kludex commented Dec 27, 2023

I think the problem here is that you didn't receive a message saying "No files were modified."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants