Fix reading from a large compressed file using external process #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn’t make sense to require a sleep() because real usage of the library will not sleep either.
marcelm
changed the title
|
I pushed another commit that appears to fix the problem: By terminating the process first (and the thread afterwards), the problem can be circumvented. |
rhpvorderman
approved these changes
Jun 4, 2024
|
Looks good to me! I am sorry I did not catch this during development of the feature. |
|
Hey no worries! Thank you for the quick support and the excellent library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the uncompressed data was "large", but issue #160 is only triggered if the compressed data is large (in this case, larger than 128 kB), which apparently exceeds some input buffer.
This only ensures the tests are failing, no fix yet.This includes an attempt at a fix where the process is first terminated and then the reader thread is told to stop.
See #160