Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Norm and SemiNorm are not clear and probably wrong #160

Open
campospinto opened this issue Jul 16, 2024 · 1 comment
Open

Norm and SemiNorm are not clear and probably wrong #160

campospinto opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation enhancement New feature or request

Comments

@campospinto
Copy link
Collaborator

campospinto commented Jul 16, 2024

No docstring is provided and it is not clear whether these objects represent the square of a norm, or a norm itself (eg when assembled). Also, it should be possible to add two (semi)norms.

Also, their evaluation after discretization is sometimes wrong: see Psydac issue #campospinto/psydac_dev#12

@campospinto campospinto added enhancement New feature or request documentation labels Jul 16, 2024
@campospinto campospinto self-assigned this Jul 16, 2024
@campospinto campospinto changed the title Norm and SemiNorm interfaces are not clear Norm and SemiNorm are not clear and probably wrong Jul 19, 2024
@campospinto campospinto added the bug Something isn't working label Jul 19, 2024
@e-moral-sanchez
Copy link
Contributor

e-moral-sanchez commented Feb 19, 2025

At the moment the L2 norm of Sympde does $\sqrt{\int_D u_h(x)\cdot u_h(x) dx}$, instead of $\sqrt{\int_D u_h(x)\cdot \overline{u_h(x)} dx}$

I think that the problem is in the Inner class, line https://github.com/pyccel/sympde/blob/fdc19138e86948cb72c8ab8bee7f58020a57dc7a/sympde/calculus/core.py#L510C22-L510C25 where it does c = Mul(*c1)*Mul(*c2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants