You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name ProductFemSpace is ambiguous: seems to be used only for multi-patch spaces, but a space of vector-valued fields (a VectorFemSpace) is also a product of FEM spaces...
-> We should rename it as MultipatchFemSpace
The "product" ambiguity is made worse by the flag function Vh.is_product which means either multi-patch or vector-valued (see for instance in the FemField constructor where its is understood as vector-valued...)
-> We should replace it by Vh.is_multipatch and Vh.is_vector_valued
The ProductFemSpaceconstructor may not return a ProductFemSpace, so the code is not easy to follow.
-> We should use a factory function instead, with a clear docstring
The text was updated successfully, but these errors were encountered:
The name ProductFemSpace is ambiguous: seems to be used only for multi-patch spaces, but a space of vector-valued fields (a
VectorFemSpace
) is also a product of FEM spaces...-> We should rename it as
MultipatchFemSpace
The "product" ambiguity is made worse by the flag function Vh.is_product which means either multi-patch or vector-valued (see for instance in the
FemField
constructor where its is understood as vector-valued...)-> We should replace it by
Vh.is_multipatch
andVh.is_vector_valued
The
ProductFemSpace
constructor may not return aProductFemSpace
, so the code is not easy to follow.-> We should use a factory function instead, with a clear docstring
The text was updated successfully, but these errors were encountered: