Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and improve ProductFemSpace class #460

Open
yguclu opened this issue Feb 21, 2025 · 0 comments · May be fixed by #468
Open

Rename and improve ProductFemSpace class #460

yguclu opened this issue Feb 21, 2025 · 0 comments · May be fixed by #468
Labels
Next Release Must be in next release

Comments

@yguclu
Copy link
Member

yguclu commented Feb 21, 2025

  1. The name ProductFemSpace is ambiguous: seems to be used only for multi-patch spaces, but a space of vector-valued fields (a VectorFemSpace) is also a product of FEM spaces...

    -> We should rename it as MultipatchFemSpace

  2. The "product" ambiguity is made worse by the flag function Vh.is_product which means either multi-patch or vector-valued (see for instance in the FemField constructor where its is understood as vector-valued...)

    -> We should replace it by Vh.is_multipatch and Vh.is_vector_valued

  3. The ProductFemSpace constructor may not return a ProductFemSpace, so the code is not easy to follow.

    -> We should use a factory function instead, with a clear docstring

@yguclu yguclu added the Next Release Must be in next release label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Release Must be in next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant