Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_sketch description of blocking behavior contradicts code #46

Closed
camblomquist opened this issue Dec 1, 2022 · 2 comments
Closed

Comments

@camblomquist
Copy link

Blocking is not supported on OSX. This is because of the (current) limitations of py5 on OSX. If the block parameter is set to True, a warning message will appear and it will be changed to False.

However, attempting to run_sketch with block=False will print the following error

On OSX, blocking is manditory when Sketch is not run through Jupyter. This applies to all renderers.

It appears that the doc is referring specifically to blocking behavior when running through Jupyter on OSX, which is correct according to https://github.com/py5coding/py5generator/blob/main/py5_resources/py5_module/py5/sketch.py#L233

@hx2A
Copy link
Collaborator

hx2A commented Dec 1, 2022

@camblomquist , thanks for identifying this point of confusion.

Your first quote is from the run_sketch() documentation, which I can see is out of date. What is written there was true for py5 earlier this year but was not updated as I made some improvements to the OSX issues.

What is current is the Special Notes for OSX Users. That page provides more info and correct info about py5 on OSX.

I'll fix the documentation issue in the near future.

@hx2A
Copy link
Collaborator

hx2A commented Mar 10, 2023

This is now fixed

@hx2A hx2A closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants