Skip to content

ModelChain.prepare_inputs can succeed with missing dhi #1092

@wfvining

Description

@wfvining

From the docstring for ModelChain.prepare_inputs() I believe the method should fail if weather does not have a dhi column.

The validation checks for 'ghi' twice, but not 'dhi'

self._verify_df(weather, required=['ghi', 'dni', 'ghi'])

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions