Skip to content

Serve the output directory from compile.purescript.org #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2020
Merged

Serve the output directory from compile.purescript.org #159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9e6e0
Serve the output directory from compile.purescript.org
hdgarrood May 2, 2020
f3ba2a7
Only serve JS files
hdgarrood May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,8 @@ server {
location / {
proxy_pass http://127.0.0.1:8081;
}

location /output {
alias /var/www/trypurescript/staging/.psci_modules/node_modules;
Copy link
Contributor

@natefaubion natefaubion May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a concern that this also potentially serves very large externs? Is it possible to glob only js files?

Copy link
Collaborator Author

@hdgarrood hdgarrood May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably not a bad idea. I think it should be possible, I'll play around with it a bit.

Copy link
Collaborator Author

@hdgarrood hdgarrood May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is pretty straightforward. There's even an example in the docs which covers pretty much this exact use case: http://nginx.org/en/docs/http/ngx_http_core_module.html#location

}
}