is it fine if onError, onSuccess is invoked after the computation is canceled? #148
Description
The lib i'm wrapping has no cancellation, this is what i have now:
exports._sendAsync = function (provider) {
return function (request) {
return function(onError, onSuccess) {
var canceled = false;
provider.sendAsync(request, function(err, succ) {
if (canceled) {
return;
} else if (err) {
onError(err);
} else {
onSuccess(succ);
}
});
return function (cancelError, onCancelerError, onCancelerSuccess) {
canceled = true;
onCancelerSuccess();
};
};
};
};my question is, is the canceled staff required, or this version will be fine too:
exports._sendAsync = function (provider) {
return function (request) {
return function(onError, onSuccess) {
provider.sendAsync(request, function(err, succ) {
if (err) {
onError(err);
} else {
onSuccess(succ);
}
});
return function (cancelError, onCancelerError, onCancelerSuccess) {
onCancelerSuccess();
};
};
};
};