Remove switch on ceremony submit #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
After photo (PR preview) |
ericswpark
requested changes
Mar 29, 2025
Member
ericswpark
left a comment
ericswpark
left a comment
There was a problem hiding this comment.
I think it might be better to have the "Generate" button under the "1. Generate" section, and a "Register" button under the "2. Register" section.
To guide the user, it would be great if the entirety of the "2. Register" section could be greyed out until the user has completed the first section.
ericswpark
approved these changes
Apr 2, 2025
Member
ericswpark
left a comment
ericswpark
left a comment
There was a problem hiding this comment.
Messaged previously, previous review suitable as separate PR
ericswpark
force-pushed
the
matthew/no-more-switch
branch
from
e73d622 to
55b9e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That switch is kinda useless isn't it? Why hide registering behind that? Maybe there are good reasons, but in case we decide there aren't, this PR removes the switch.