Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diredfl-no-priv when missing a directory/link priv indicator #15

Closed
slotThe opened this issue May 7, 2022 · 4 comments
Closed

Add diredfl-no-priv when missing a directory/link priv indicator #15

slotThe opened this issue May 7, 2022 · 4 comments

Comments

@slotThe
Copy link

slotThe commented May 7, 2022

Hi,

right now diredfl-no-priv is only applied when an ordinary privilege (rwx) is missing; for "special" indicators, like directories and links, no face is used. When font-locking the file modes column with a background colour, this can look rather awkward:

2022-05-06-191209_728x209_scrot

Would it be possible to give that first - the diredfl-no-priv face as well?

@purcell
Copy link
Owner

purcell commented May 7, 2022

Are you sure the face being applied to the leading d/l is diredfl-no-priv?

@slotThe
Copy link
Author

slotThe commented May 7, 2022

Sorry, I wasn't very clear. The face applied to d and l is indeed dired-dir-priv and dired-rare-priv, respectively. However, there is no face applied to - in place of d or l (i.e., if these privileges are missing). For the other privileges (- in the spots of r, w, and x), the diredfl-no-priv is used instead of diredfl-{read,write,exec}-priv; I'd like that to happen for a "missing" d or l as well

@purcell purcell closed this as completed in 62b559e May 8, 2022
@purcell
Copy link
Owner

purcell commented May 8, 2022

Done, I think!

@slotThe
Copy link
Author

slotThe commented May 8, 2022

Indeed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants